Skip to content

[9.0] Remove unused parameter from AbstractSearchAsyncAction.onShardResult (#121887) #121891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

[9.0] Remove unused parameter from AbstractSearchAsyncAction.onShardResult (#121887) #121891

wants to merge 6 commits into from

Conversation

original-brownbear
Copy link
Contributor

Backports the following commits to 9.0:

@original-brownbear
Remove unused parameter from AbstractSearchAsyncAction.onShardResult (e…
23de533 
…lastic#121887)

Recent cleanups made the shard iterator unused on this method.
@original-brownbear original-brownbear added :Search Foundations/Search Catch all for Search Foundations >non-issue auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch labels Feb 6, 2025
@elasticsearchmachine elasticsearchmachine mentioned this pull request Feb 6, 2025
Merged
@drempapis
Copy link
Contributor

@elasticmachine test this please

@drempapis
Copy link
Contributor

@elasticmachine test this please

@drempapis
Copy link
Contributor

This backport PR is not compatible with the code in the 9.0 branch. The current PR is based on several refactorings that were applied only to the 8.19 and 9.1 branches, and were not backported to 9.0.
For example:
#120593
#116891
#126933

@drempapis drempapis closed this Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@drempapis drempapis

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >non-issue :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v9.0.5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@original-brownbear @drempapis @elasticsearchmachine @smalyshev